Mercurial > people > rkennke > jdk9-shenandoah-final > nashorn
changeset 456:624f8be5c3fe
8020809: Java adapter should not allow overriding of caller sensitive methods
Reviewed-by: jlaskey, sundar
author | attila |
---|---|
date | Thu, 18 Jul 2013 16:22:25 +0200 |
parents | e3307f1a30e5 |
children | 4b06441b7624 |
files | src/jdk/nashorn/internal/runtime/linker/JavaAdapterBytecodeGenerator.java test/script/trusted/JDK-8020809.js test/script/trusted/JDK-8020809.js.EXPECTED |
diffstat | 3 files changed, 56 insertions(+), 2 deletions(-) [+] |
line wrap: on
line diff
--- a/src/jdk/nashorn/internal/runtime/linker/JavaAdapterBytecodeGenerator.java Thu Jul 18 18:08:26 2013 +0530 +++ b/src/jdk/nashorn/internal/runtime/linker/JavaAdapterBytecodeGenerator.java Thu Jul 18 16:22:25 2013 +0200 @@ -45,6 +45,7 @@ import java.lang.invoke.MethodHandle; import java.lang.invoke.MethodType; +import java.lang.reflect.AccessibleObject; import java.lang.reflect.Constructor; import java.lang.reflect.Method; import java.lang.reflect.Modifier; @@ -66,6 +67,7 @@ import jdk.nashorn.internal.runtime.Context; import jdk.nashorn.internal.runtime.ScriptFunction; import jdk.nashorn.internal.runtime.ScriptObject; +import sun.reflect.CallerSensitive; /** * Generates bytecode for a Java adapter class. Used by the {@link JavaAdapterFactory}. @@ -378,7 +380,7 @@ boolean gotCtor = false; for (final Constructor<?> ctor: superClass.getDeclaredConstructors()) { final int modifier = ctor.getModifiers(); - if((modifier & (Modifier.PUBLIC | Modifier.PROTECTED)) != 0) { + if((modifier & (Modifier.PUBLIC | Modifier.PROTECTED)) != 0 && !isCallerSensitive(ctor)) { generateConstructors(ctor); gotCtor = true; } @@ -843,7 +845,7 @@ } if (Modifier.isPublic(m) || Modifier.isProtected(m)) { final MethodInfo mi = new MethodInfo(typeMethod); - if (Modifier.isFinal(m)) { + if (Modifier.isFinal(m) || isCallerSensitive(typeMethod)) { finalMethods.add(mi); } else if (!finalMethods.contains(mi) && methodInfos.add(mi)) { if (Modifier.isAbstract(m)) { @@ -920,4 +922,8 @@ final Class<?> superClass = c1.getSuperclass(); return superClass.isAssignableFrom(c2) ? superClass : assignableSuperClass(superClass, c2); } + + private static boolean isCallerSensitive(final AccessibleObject e) { + return e.getAnnotation(CallerSensitive.class) != null; + } }
--- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/test/script/trusted/JDK-8020809.js Thu Jul 18 16:22:25 2013 +0200 @@ -0,0 +1,47 @@ +/* + * Copyright (c) 2010, 2013, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + +/** + * JDK-8020809: Java adapter should not allow overriding of caller sensitive methods + * + * @test + * @run + */ + +// This test runs as trusted as we need the +// "enableContextClassLoaderOverride" runtime permission. + +var T = Java.extend(java.lang.Thread, { + getContextClassLoader: function() { + // Since getContextClassLoader is caller sensitive, this won't + // actually act as an override; it will be ignored. If we could + // invoke it, it would be an error. + throw new Error() + } +}) + +// Retrieve the context ClassLoader on our Thread adapter, ensure the +// method was not, in fact, overridden. +var cl = (new T()).contextClassLoader + +print("cl is class loader: " + (cl instanceof java.lang.ClassLoader))