Mercurial > people > rkennke > jdk9-shenandoah-final > nashorn
changeset 1277:92958064570c
8079424: code generator for discarded boolean logical operation has an extra pop
Reviewed-by: lagergren, sundar
author | attila |
---|---|
date | Fri, 15 May 2015 10:19:37 +0200 |
parents | 2054d01ae326 |
children | 4dc7eb763139 |
files | src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/codegen/CodeGenerator.java test/script/basic/JDK-8079424.js |
diffstat | 2 files changed, 50 insertions(+), 1 deletions(-) [+] |
line wrap: on
line diff
--- a/src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/codegen/CodeGenerator.java Thu May 14 20:14:44 2015 -0700 +++ b/src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/codegen/CodeGenerator.java Fri May 15 10:19:37 2015 +0200 @@ -3798,7 +3798,6 @@ emitBranch(binaryNode, onTrue, true); if (isCurrentDiscard) { method.label(onTrue); - method.pop(); } else { method.load(false); method._goto(skip);
--- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/test/script/basic/JDK-8079424.js Fri May 15 10:19:37 2015 +0200 @@ -0,0 +1,50 @@ +/* + * Copyright (c) 2015 Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + +/** + * JDK-8079424: code generator for discarded boolean logical operation has an extra pop + * + * @test + * @run + */ + +// If the compiler manages to compile all of these, the test passes. +void (true && true); +void (true && false); +void (false && true); +void (false && false); + +void (true || true); +void (true || false); +void (false || true); +void (false || false); + +void (1 && 1); +void (1 && 0); +void (0 && 1); +void (0 && 0); + +void (1 || 1); +void (1 || 0); +void (0 || 1); +void (0 || 0);