Mercurial > people > rkennke > jdk9-shenandoah-final > nashorn
changeset 966:c0dd84255936
8055034: jjs exits interactive mode if exception was thrown when trying to print value of last evaluated expression
Reviewed-by: jlaskey, attila
author | sundar |
---|---|
date | Wed, 13 Aug 2014 21:03:37 +0530 |
parents | e84cfe70c504 |
children | 72c86f6eb628 |
files | src/jdk/nashorn/tools/Shell.java test/script/nosecurity/JDK-8055034.js test/script/nosecurity/JDK-8055034.js.EXPECTED |
diffstat | 3 files changed, 70 insertions(+), 7 deletions(-) [+] |
line wrap: on
line diff
--- a/src/jdk/nashorn/tools/Shell.java Wed Aug 13 15:00:24 2014 +0530 +++ b/src/jdk/nashorn/tools/Shell.java Wed Aug 13 21:03:37 2014 +0530 @@ -442,19 +442,16 @@ continue; } - Object res; try { - res = context.eval(global, source, global, "<shell>", env._strict); + final Object res = context.eval(global, source, global, "<shell>", env._strict); + if (res != ScriptRuntime.UNDEFINED) { + err.println(JSType.toString(res)); + } } catch (final Exception e) { err.println(e); if (env._dump_on_error) { e.printStackTrace(err); } - continue; - } - - if (res != ScriptRuntime.UNDEFINED) { - err.println(JSType.toString(res)); } } } finally {
--- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/test/script/nosecurity/JDK-8055034.js Wed Aug 13 21:03:37 2014 +0530 @@ -0,0 +1,64 @@ +/* + * Copyright (c) 2014, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + +/** + * JDK-8055034: jjs exits interactive mode if exception was thrown when trying to print value of last evaluated expression + * + * @test + * @option -scripting + * @run + */ + +// assume that this script is run with "nashorn.jar" System +// property set to relative or absolute path of nashorn.jar + +if (typeof fail != 'function') { + fail = print; +} + +var System = java.lang.System; +var File = java.io.File; +var javahome = System.getProperty("java.home"); +var nashornJar = new File(System.getProperty("nashorn.jar")); +if (! nashornJar.isAbsolute()) { + nashornJar = new File(".", nashornJar); +} +var nashornJarDir = nashornJar.parentFile.absolutePath; + +// we want to use nashorn.jar passed and not the one that comes with JRE +var jjsCmd = javahome + "/../bin/jjs"; +jjsCmd += " -J-Djava.ext.dirs=" + nashornJarDir; +jjsCmd = jjsCmd.toString().replaceAll(/\//g, File.separater); + +$EXEC(jjsCmd, "var x = Object.create(null);\nx;\nprint('PASSED');\nexit(0)"); + +// $ERR has all interactions including prompts! Just check for error substring. +var err = $ERR.trim(); +if (! err.contains("TypeError: Cannot get default string value")) { + fail("Error stream does not contain expected error message"); +} + +// should print "PASSED" +print($OUT.trim()); +// exit code should be 0 +print("exit code = " + $EXIT);